Skip to content

SolidQueue::ClaimedExecution.fail_all_with return early when the record is empty #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

SolidQueue::ClaimedExecution.fail_all_with return early when the record is empty #643

merged 1 commit into from
Sep 30, 2025

Conversation

yokonao
Copy link
Contributor

@yokonao yokonao commented Sep 28, 2025

close #641

Prevents unnecessary events from being emitted when SolidQueue::ClaimedExecution is empty.

@yokonao yokonao mentioned this pull request Sep 28, 2025
Closed
rosa
rosa approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yokonao! 🙏

@rosa rosa merged commit 1957f57 into rails:main Sep 30, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosa rosa rosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary warning on Solid Queue startup
2 participants
@yokonao @rosa